From 44f56a077369b5e32674ece240211071de6176ae Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Thu, 14 Jun 2018 22:48:37 +0200 Subject: [PATCH] Refactor `join("")` to `join`. --- Library/Homebrew/rubocops/extend/formula_cop.rb | 2 +- Library/Homebrew/test/cask/download_strategy_spec.rb | 2 +- Library/Homebrew/test/cask/dsl_spec.rb | 2 +- Library/Homebrew/test/cask/pkg_spec.rb | 2 +- Library/Homebrew/test/cask/system_command_spec.rb | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Library/Homebrew/rubocops/extend/formula_cop.rb b/Library/Homebrew/rubocops/extend/formula_cop.rb index 02bbb7c6d9..362a5134c0 100644 --- a/Library/Homebrew/rubocops/extend/formula_cop.rb +++ b/Library/Homebrew/rubocops/extend/formula_cop.rb @@ -460,7 +460,7 @@ module RuboCop when :str node.str_content when :dstr - node.each_child_node(:str).map(&:str_content).join("") + node.each_child_node(:str).map(&:str_content).join when :const node.const_name when :sym diff --git a/Library/Homebrew/test/cask/download_strategy_spec.rb b/Library/Homebrew/test/cask/download_strategy_spec.rb index ed8cd01ef6..3a69edaaf4 100644 --- a/Library/Homebrew/test/cask/download_strategy_spec.rb +++ b/Library/Homebrew/test/cask/download_strategy_spec.rb @@ -148,7 +148,7 @@ describe "download strategies", :cask do "DBw2KdR24q9t1wfjS9LUzelf5TWk6ojj8p9%2FHjl%2Fi%2FVCXN", "N4o1mW%2FMayy2tTY1qcC%2FTmqI1ulZS8SNuaSgr9Iys9oDF1%2", "BPK%2B4Sg==", - ].join("") + ].join end describe "#tarball_path" do diff --git a/Library/Homebrew/test/cask/dsl_spec.rb b/Library/Homebrew/test/cask/dsl_spec.rb index 67fcb027a8..2500a53fa3 100644 --- a/Library/Homebrew/test/cask/dsl_spec.rb +++ b/Library/Homebrew/test/cask/dsl_spec.rb @@ -20,7 +20,7 @@ describe Hbc::DSL, :cask do } it "prints a warning that it has encountered an unexpected method" do - expected = Regexp.compile(<<~EOS.lines.map(&:chomp).join("")) + expected = Regexp.compile(<<~EOS.lines.map(&:chomp).join) (?m) Warning: .* diff --git a/Library/Homebrew/test/cask/pkg_spec.rb b/Library/Homebrew/test/cask/pkg_spec.rb index f92d6854e2..6a7247058e 100644 --- a/Library/Homebrew/test/cask/pkg_spec.rb +++ b/Library/Homebrew/test/cask/pkg_spec.rb @@ -134,7 +134,7 @@ describe Hbc::Pkg, :cask do #{volume} paths - #{(pkg_files + pkg_directories).map { |f| "#{f}" }.join("")} + #{(pkg_files + pkg_directories).map { |f| "#{f}" }.join} diff --git a/Library/Homebrew/test/cask/system_command_spec.rb b/Library/Homebrew/test/cask/system_command_spec.rb index 6899d4fa65..6e7397931f 100644 --- a/Library/Homebrew/test/cask/system_command_spec.rb +++ b/Library/Homebrew/test/cask/system_command_spec.rb @@ -109,7 +109,7 @@ describe Hbc::SystemCommand, :cask do end it "echoes only STDOUT" do - expected = [1, 3, 5].map { |i| "#{i}\n" }.join("") + expected = [1, 3, 5].map { |i| "#{i}\n" }.join expect { described_class.run(command, options) }.to output(expected).to_stdout