Handle Homebrew.failed in spec_helper.

Library/Homebrew/test/spec_helper.rb

@@ -33,6 +33,8 @@ RSpec.configure do |config|
     begin
       TEST_DIRECTORIES.each(&:mkpath)
 
+      @__homebrew_failed = Homebrew.failed?
+
       @__files_before_test = Find.find(TEST_TMPDIR).map { |f| f.sub(TEST_TMPDIR, "") }
 
       @__argv = ARGV.dup
@@ -72,6 +74,10 @@ RSpec.configure do |config|
         file leak detected:
         #{diff.map { |f| "  #{f}" }.join("\n")}
       EOS
+
+      Homebrew.failed = @__homebrew_failed
     end
   end
 end
+
+RSpec::Matchers.alias_matcher :have_failed, :be_failed

Library/Homebrew/test/utils_spec.rb

@@ -1,7 +1,5 @@
 require "utils"
 
-RSpec::Matchers.alias_matcher :have_failed, :be_failed
-
 describe "globally-scoped helper methods" do
   let(:dir) { @dir = Pathname.new(Dir.mktmpdir) }
 
@@ -13,15 +11,11 @@ describe "globally-scoped helper methods" do
 
   describe "#ofail" do
     it "sets Homebrew.failed to true" do
-      begin
+      expect {
-        shutup do
+        ofail "foo"
-          ofail "foo"
+      }.to output("Error: foo\n").to_stderr
-        end
 
-        expect(Homebrew).to have_failed
+      expect(Homebrew).to have_failed
-      ensure
-        Homebrew.failed = false
-      end
     end
   end