From 441df3d866df9c4cae5503945e03036bae71dbbd Mon Sep 17 00:00:00 2001
From: Issy Long <me@issyl0.co.uk>
Date: Sun, 24 Jul 2022 23:32:48 +0100
Subject: [PATCH] dev-cmd/contributions: Switch `--email` to be a named arg

- This way we can do the more intuitive:

```
$ brew contributions --repos=brew,core rslpolster@gmail.com
Person rslpolster@gmail.com directly authored 1580 commits and co-authored 125 commits to brew, core in all time.
```
---
 Library/Homebrew/dev-cmd/contributions.rb | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/Library/Homebrew/dev-cmd/contributions.rb b/Library/Homebrew/dev-cmd/contributions.rb
index ff29bb9a8f..c727d04f1f 100755
--- a/Library/Homebrew/dev-cmd/contributions.rb
+++ b/Library/Homebrew/dev-cmd/contributions.rb
@@ -14,14 +14,11 @@ module Homebrew
   def contributions_args
     Homebrew::CLI::Parser.new do
       usage_banner <<~EOS
-        `contributions`
+        `contributions [email]`
 
         Contributions to Homebrew repos for a user.
       EOS
 
-      flag "--email=",
-           description: "A user's email address that they commit with."
-
       flag "--from=",
            description: "Date (ISO-8601 format) to start searching contributions."
 
@@ -32,7 +29,7 @@ module Homebrew
                   description: "The Homebrew repositories to search for contributions in. " \
                                "Comma separated. Supported repos: #{SUPPORTED_REPOS.join(", ")}."
 
-      named_args :none
+      named_args :email
     end
   end
 
@@ -40,7 +37,7 @@ module Homebrew
   def contributions
     args = contributions_args.parse
 
-    return ofail "`--repos` and `--email` are required." if !args[:repos] || !args[:email]
+    return ofail "`--repos` is required." if args.repos.empty?
 
     commits = 0
     coauthorships = 0
@@ -57,7 +54,7 @@ module Homebrew
       coauthorships += git_log_coauthor_cmd(repo_path, args)
     end
 
-    sentence = "Person #{args[:email]} directly authored #{commits} commits"
+    sentence = "Person #{args.named.first} directly authored #{commits} commits"
     sentence += " and co-authored #{coauthorships} commits"
     sentence += " to #{args[:repos].join(", ")}"
     sentence += if args[:from] && args[:to]
@@ -83,7 +80,7 @@ module Homebrew
 
   sig { params(repo_path: String, args: Homebrew::CLI::Args).returns(Integer) }
   def git_log_author_cmd(repo_path, args)
-    cmd = "git -C #{repo_path} log --oneline --author=#{args[:email]}"
+    cmd = "git -C #{repo_path} log --oneline --author=#{args.named.first}"
     cmd += " --before=#{args[:to]}" if args[:to]
     cmd += " --after=#{args[:from]}" if args[:from]
 
@@ -96,7 +93,7 @@ module Homebrew
     cmd += " --format='%(trailers:key=Co-authored-by:)'"
     cmd += " --before=#{args[:to]}" if args[:to]
     cmd += " --after=#{args[:from]}" if args[:from]
-    cmd += " | grep #{args[:email]}"
+    cmd += " | grep #{args.named.first}"
 
     `#{cmd} | wc -l`.strip.to_i
   end