From 4398e7bf79fd9816a0d005c895caa55cd6c5a707 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Mon, 29 Jun 2020 09:50:51 +0100 Subject: [PATCH] Revert "cask/pkg_spec: remove flaky test." This reverts commit 924af100b73d24dffb2199fa46ae118e8b3bbb29. --- Library/Homebrew/test/cask/pkg_spec.rb | 28 ++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/Library/Homebrew/test/cask/pkg_spec.rb b/Library/Homebrew/test/cask/pkg_spec.rb index fdcfe65fb6..486ab8f822 100644 --- a/Library/Homebrew/test/cask/pkg_spec.rb +++ b/Library/Homebrew/test/cask/pkg_spec.rb @@ -6,6 +6,34 @@ describe Cask::Pkg, :cask do let(:empty_response) { double(stdout: "", plist: { "volume" => "/", "install-location" => "", "paths" => {} }) } let(:pkg) { described_class.new("my.fake.pkg", fake_system_command) } + it "removes files and dirs referenced by the pkg" do + some_files = Array.new(3) { Pathname.new(Tempfile.new("plain_file").path) } + allow(pkg).to receive(:pkgutil_bom_files).and_return(some_files) + + some_specials = Array.new(3) { Pathname.new(Tempfile.new("special_file").path) } + allow(pkg).to receive(:pkgutil_bom_specials).and_return(some_specials) + + some_dirs = Array.new(3) { mktmpdir } + allow(pkg).to receive(:pkgutil_bom_dirs).and_return(some_dirs) + + root_dir = Pathname.new(mktmpdir) + allow(pkg).to receive(:root).and_return(root_dir) + + allow(pkg).to receive(:forget) + + pkg.uninstall + + some_files.each do |file| + expect(file).not_to exist + end + + some_dirs.each do |dir| + expect(dir).not_to exist + end + + expect(root_dir).not_to exist + end + context "pkgutil" do it "forgets the pkg" do allow(fake_system_command).to receive(:run!).with(