admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

commands: explain change in command description splitting

Browse Source 
A comment here would help the reader to understand the need for this
splitting logic, which is not so straightforward.

Addresses review comment in
https://github.com/Homebrew/brew/pull/15146#discussion_r1157361656.

Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
This commit is contained in:
Ruoyu Zhong 2023-04-04 22:50:40 +08:00
parent 0048a86673
commit 4305443c9c
No known key found for this signature in database
GPG Key ID: 42F3B7E577C2156A
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/commands.rb
View File

@ -203,6 +203,10 @@ module Commands
if (cmd_parser = Homebrew::CLI::Parser.from_cmd_path(path)) if (cmd_parser = Homebrew::CLI::Parser.from_cmd_path(path))
if short if short
# We only consider a dot as a full stop if it is either followed by a
# whitespace or at the end of the description. In this way we can
# prevent cutting off a sentence in the middle due to dots in URLs or
# paths.
cmd_parser.description.split(/\.(?>\s|$)/).first cmd_parser.description.split(/\.(?>\s|$)/).first
else else
cmd_parser.description cmd_parser.description