admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

formula_installer: detect recursive dependencies.

Browse Source 
Detect recursive dependencies and refuse to install them providing
instruction on exactly what is depending on what.

Fixes #1933.
This commit is contained in:
Mike McQuaid 2017-02-21 21:29:32 +00:00
parent ed7290abb4
commit 42bb19a631
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
Library/Homebrew/formula_installer.rb
View File

@ -151,6 +151,28 @@ class FormulaInstaller
recursive_deps = formula.recursive_dependencies recursive_deps = formula.recursive_dependencies
recursive_formulae = recursive_deps.map(&:to_formula) recursive_formulae = recursive_deps.map(&:to_formula)
recursive_dependencies = []
recursive_formulae.each do |dep|
dep_recursive_dependencies = dep.recursive_dependencies.map(&:to_s)
if dep_recursive_dependencies.include?(formula.name)
recursive_dependencies << "#{formula.full_name} depends on #{dep.full_name}"
recursive_dependencies << "#{dep.full_name} depends on #{formula.full_name}"
end
end
unless recursive_dependencies.empty?
raise CannotInstallFormulaError, <<-EOS.undent
#{formula.full_name} contains a recursive dependency on itself:
#{recursive_dependencies.join("\n ")}
EOS
end
if recursive_formulae.flat_map(&:recursive_dependencies).map(&:to_s).include?(formula.name)
raise CannotInstallFormulaError, <<-EOS.undent
#{formula.full_name} contains a recursive dependency on itself!
EOS
end
if ENV["HOMEBREW_CHECK_RECURSIVE_VERSION_DEPENDENCIES"] if ENV["HOMEBREW_CHECK_RECURSIVE_VERSION_DEPENDENCIES"]
version_hash = {} version_hash = {}
version_conflicts = Set.new version_conflicts = Set.new