admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #5216 from GauthamGoli/audit-args-fix

Browse Source 
audit: Don't mutate args
This commit is contained in:
Mike McQuaid 2018-10-31 08:44:49 +00:00 committed by GitHub
commit 422257067c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/dev-cmd/audit.rb
View File

@ -134,7 +134,6 @@ module Homebrew
if only_cops if only_cops
options[:only_cops] = only_cops options[:only_cops] = only_cops
args.only = ["style"]
elsif args.new_formula? elsif args.new_formula?
nil nil
elsif strict elsif strict
@ -151,7 +150,8 @@ module Homebrew
new_formula_problem_lines = [] new_formula_problem_lines = []
ff.sort.each do |f| ff.sort.each do |f|
options = { new_formula: new_formula, strict: strict, online: online, only: args.only, except: args.except } only = only_cops ? ["style"] : args.only
options = { new_formula: new_formula, strict: strict, online: online, only: only, except: args.except }
options[:style_offenses] = style_results.file_offenses(f.path) options[:style_offenses] = style_results.file_offenses(f.path)
fa = FormulaAuditor.new(f, options) fa = FormulaAuditor.new(f, options)
fa.audit fa.audit