admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: make audit_revision more generic.

Browse Source 
This will allow it to be used for checking other attributes too.
This commit is contained in:
Mike McQuaid 2016-08-18 12:55:19 +01:00
parent eea0da362b
commit 41f6334b5b
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Library/Homebrew/cmd/audit.rb
View File

@ -628,11 +628,20 @@ class FormulaAuditor
return unless formula.tap.git? # git log is required return unless formula.tap.git? # git log is required
fv = FormulaVersions.new(formula, :max_depth => 10) fv = FormulaVersions.new(formula, :max_depth => 10)
revision_map = fv.version_attributes_map([:revision], "origin/master") attributes = [:revision]
revisions = revision_map[formula.version] attributes_map = fv.version_attributes_map(attributes, "origin/master")
if !revisions.empty?
problem "revision should not decrease" if formula.revision < revisions.max attributes.each do |attribute|
elsif formula.revision != 0 attributes_for_version = attributes_map[attribute][formula.version]
if !attributes_for_version.empty?
if formula.send(attribute) < attributes_for_version.max
problem "#{attribute} should not decrease"
end
end
end
revision_map = attributes_map[:revision]
if formula.revision != 0
if formula.stable if formula.stable
if revision_map[formula.stable.version].empty? # check stable spec if revision_map[formula.stable.version].empty? # check stable spec
problem "revision should be removed" problem "revision should be removed"