admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: give better suggestion on git/hg dependency

Browse Source 
Closes Homebrew/homebrew#36959.

Signed-off-by: Xu Cheng <xucheng@me.com>
This commit is contained in:
Xu Cheng 2015-02-19 18:27:50 +08:00
parent 6dd51ff399
commit 40e6426322
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/cmd/audit.rb
View File

@ -174,8 +174,12 @@ class FormulaAuditor
Or if it is indeed a runtime denpendency Or if it is indeed a runtime denpendency
depends_on "#{dep}" => :run depends_on "#{dep}" => :run
EOS EOS
when "git", "ruby", "mercurial" when "git"
problem "Don't use #{dep} as a dependency. We allow non-Homebrew #{dep} installations." problem "Use `depends_on :git` instead of `depends_on 'git'`"
when "mercurial"
problem "Use `depends_on :hg` instead of `depends_on 'mercurial'`"
when "ruby"
problem "Don't use ruby as a dependency. We allow non-Homebrew ruby installations."
when 'gfortran' when 'gfortran'
problem "Use `depends_on :fortran` instead of `depends_on 'gfortran'`" problem "Use `depends_on :fortran` instead of `depends_on 'gfortran'`"
when 'open-mpi', 'mpich2' when 'open-mpi', 'mpich2'