admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: stop red-flagging devel-only

Browse Source 
Currently the bot is failing certain devel-only formulae because it
thinks having ` devel ` defined with an added ` head ` defined
as well = a head-only formula.

```
==> audit problems
docker-machine:
 * Head-only (no stable download)
```

This is a pretty simple fix for that problem:

```
==> brew style docker-machine
1 file inspected, no offenses detected
```

Closes Homebrew/homebrew#36197.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
This commit is contained in:
Dominyk Tiller 2015-01-24 23:36:33 +00:00 committed by Mike McQuaid
parent 8fc3c4c8e9
commit 40ddea637a
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/cmd/audit.rb
View File

@ -359,6 +359,10 @@ class FormulaAuditor
problem "Head-only (no stable download)" problem "Head-only (no stable download)"
end end
if devel_only?(formula) && formula.tap != "homebrew/homebrew-devel-only"
problem "Devel-only (no stable download)"
end
%w[Stable Devel HEAD].each do |name| %w[Stable Devel HEAD].each do |name|
next unless spec = formula.send(name.downcase) next unless spec = formula.send(name.downcase)
@ -696,7 +700,11 @@ class FormulaAuditor
end end
def head_only?(formula) def head_only?(formula)
formula.head && formula.stable.nil? formula.head && formula.devel.nil? && formula.stable.nil?
end
def devel_only?(formula)
formula.devel && formula.stable.nil?
end end
end end