admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Add undeclared dependencies to Tab when installing

Browse Source 
An installed formula doesn't get optlinked until _after_ it's installed,
meaning that we can't rely on `opt_prefix` to get the right keg.

So, if not optlinked, fall back to the formula's prefix, which will be
that of the current installation.
This commit is contained in:
Alyssa Ross 2018-02-11 16:23:22 +00:00
parent 8386e6a8c1
commit 40ca03e975
No known key found for this signature in database
GPG Key ID: 6CF064D149E3ABDB
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/formula.rb
View File

@ -13,6 +13,7 @@ require "pkg_version"
require "tap" require "tap"
require "keg" require "keg"
require "migrator" require "migrator"
require "os/mac/linkage_checker"
require "extend/ENV" require "extend/ENV"
require "language/python" require "language/python"
@ -1840,9 +1841,14 @@ class Formula
end end
def undeclared_runtime_dependencies def undeclared_runtime_dependencies
return [] unless optlinked? if optlinked?
keg = Keg.new(opt_prefix)
elsif prefix.directory?
keg = Keg.new(prefix)
else
return []
end
keg = Keg.new(opt_prefix)
linkage_checker = LinkageChecker.new(keg, self) linkage_checker = LinkageChecker.new(keg, self)
dylib_formula_names = linkage_checker.brewed_dylibs.keys dylib_formula_names = linkage_checker.brewed_dylibs.keys
linked_formulae_names = dylib_formula_names - [name] linked_formulae_names = dylib_formula_names - [name]