admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Simplify offending_stanzas method - pass sorted_stanzas in directly

Browse Source 
- Otherwise we're doing the same "if inner" check twice, for no gain.
This commit is contained in:
Issy Long 2023-04-16 22:03:29 +01:00 committed by Markus Reiter
parent 9457a23430
commit 40bc235cb6
No known key found for this signature in database
GPG Key ID: 245293B51702655B
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Library/Homebrew/rubocops/cask/stanza_order.rb
View File

@ -36,7 +36,7 @@ module RuboCop
def add_offenses(stanzas, inner: false) def add_offenses(stanzas, inner: false)
sorted_stanzas = inner ? sorted_inner_stanzas(stanzas) : sorted_toplevel_stanzas sorted_stanzas = inner ? sorted_inner_stanzas(stanzas) : sorted_toplevel_stanzas
offending_stanzas(stanzas, inner: inner).each do |stanza| offending_stanzas(stanzas, sorted_stanzas).each do |stanza|
message = format(MESSAGE, stanza: stanza.stanza_name) message = format(MESSAGE, stanza: stanza.stanza_name)
add_offense(stanza.source_range_with_comments, message: message) do |corrector| add_offense(stanza.source_range_with_comments, message: message) do |corrector|
correct_stanza_index = stanzas.index(stanza) correct_stanza_index = stanzas.index(stanza)
@ -47,8 +47,7 @@ module RuboCop
end end
end end
def offending_stanzas(stanzas, inner: false) def offending_stanzas(stanzas, sorted_stanzas)
sorted_stanzas = inner ? sorted_inner_stanzas(stanzas) : sorted_toplevel_stanzas
stanza_pairs = stanzas.zip(sorted_stanzas) stanza_pairs = stanzas.zip(sorted_stanzas)
stanza_pairs.each_with_object([]) do |stanza_pair, offending_stanzas| stanza_pairs.each_with_object([]) do |stanza_pair, offending_stanzas|
stanza, sorted_stanza = *stanza_pair stanza, sorted_stanza = *stanza_pair