From 40b2340ba3396db480415a62ef18fbec3e3e019c Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Tue, 3 Aug 2021 08:51:46 +0100 Subject: [PATCH] release_notes: use safe_popen_read. Otherwise if `git log` fails (e.g. due to missing `origin/HEAD` in my case) then it will generate a release with empty release notes. --- Library/Homebrew/release_notes.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/release_notes.rb b/Library/Homebrew/release_notes.rb index 840188089e..c7d9247468 100644 --- a/Library/Homebrew/release_notes.rb +++ b/Library/Homebrew/release_notes.rb @@ -14,7 +14,7 @@ module ReleaseNotes .returns(String) } def generate_release_notes(start_ref, end_ref, markdown: false) - Utils.popen_read( + Utils.safe_popen_read( "git", "-C", HOMEBREW_REPOSITORY, "log", "--pretty=format:'%s >> - %b%n'", "#{start_ref}..#{end_ref}" ).lines.map do |s| matches = s.match(%r{.*Merge pull request #(?\d+) from (?[^/]+)/[^>]*>> - (?.*)})