admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

contributions: resolve type errors

Browse Source 
This updates the type signature for `#scan_repositories` to address a
runtime type error and to reflect the actual return type.

The logic in `#scan_repositories` to check for unsupported
repositories leads to a type error, as `#ofail` has a void return
type. To resolve this, I moved the repository verification code into
`#run` (after `repos` is defined but before it's used) and used
`#odie`, so the command will exit early with an error.

While I was at it, I updated the type for the `repos` parameter to
not be `nilable`, as it shouldn't be `nil` based on how we're
handling `repos` in `#run`.
This commit is contained in:
Sam Ford 2024-07-18 11:29:36 -04:00
parent b4b984e968
commit 403b0bf3f1
No known key found for this signature in database
GPG Key ID: 7AF5CBEE1DD6F76D
1 changed files with 22 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
Library/Homebrew/dev-cmd/contributions.rb
View File

@ -48,12 +48,20 @@ module Homebrew
results = {}
grand_totals = {}
repos = if args.repositories.blank? || args.repositories&.include?("primary")
repos = T.must(
if args.repositories.blank? || args.repositories&.include?("primary")
PRIMARY_REPOS
elsif args.repositories&.include?("all")
SUPPORTED_REPOS
else
args.repositories
end,
)
repos.each do |repo|
if SUPPORTED_REPOS.exclude?(repo)
odie "Unsupported repository: #{repo}. Try one of #{SUPPORTED_REPOS.join(", ")}."
end
end
from = args.from.presence || Date.today.prev_year.iso8601
@ -150,17 +158,18 @@ module Homebrew
]
end
sig { params(repos: T.nilable(T::Array[String]), person: String, from: String).void }
sig {
params(
repos: T::Array[String],
person: String,
from: String,
).returns(T::Hash[Symbol, T.untyped])
}
def scan_repositories(repos, person, from:)
return if repos.blank?
data = {}
return data if repos.blank?
repos.each do |repo|
if SUPPORTED_REPOS.exclude?(repo)
return ofail "Unsupported repository: #{repo}. Try one of #{SUPPORTED_REPOS.join(", ")}."
end
repo_path = find_repo_path_for_repo(repo)
tap = Tap.fetch("homebrew", repo)
unless repo_path.exist?