From 3fec64f38699b7174dfe85467587e0594e14880d Mon Sep 17 00:00:00 2001 From: Max Eisner <4730112+max-ae@users.noreply.github.com> Date: Thu, 11 Aug 2022 17:45:38 +0200 Subject: [PATCH] skip offenses for heredoc scripts and calls with custom env MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit needed for e.g. àwscli`, `hatch`, `pipenv` --- Library/Homebrew/rubocops/lines.rb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Library/Homebrew/rubocops/lines.rb b/Library/Homebrew/rubocops/lines.rb index b12be1b1b8..b7f5ced3b2 100644 --- a/Library/Homebrew/rubocops/lines.rb +++ b/Library/Homebrew/rubocops/lines.rb @@ -462,6 +462,9 @@ module RuboCop end shell_completion_node(install) do |node| + next if node.source.include?("<<~") # skip heredoc completion scripts + next if node.source.match?(/{.*=>.*}/) # skip commands needing custom ENV variables + offending_node(node) problem "Use `generate_completions_from_executable` DSL instead of `#{@offensive_node.source}`." end