add test for ENV.fortran

This commit is contained in:
Gautham Goli 2017-08-15 00:32:34 +05:30
parent 5744cd9066
commit 3fc6cc1a3a
2 changed files with 29 additions and 5 deletions

View File

@ -162,11 +162,11 @@ module RuboCop
problem "Use 'build.head?' instead of inspecting 'version'"
end
# find_instance_method_call(body_node, :ENV, :fortran) do
# next if depends_on?(:fortran)
# problem "Use `depends_on :fortran` instead of `ENV.fortran`"
# end
#
find_instance_method_call(body_node, "ENV", :fortran) do
next if depends_on?(:fortran)
problem "Use `depends_on :fortran` instead of `ENV.fortran`"
end
# find_instance_method_call(body_node, :ARGV, :include?) do |m|
# param = parameters(m).first
# next unless match = regex_match_group(param, %r{--(HEAD|devel)})

View File

@ -1141,6 +1141,30 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
end
end
it "with ENV.fortran" do
source = <<-EOS.undent
class Foo < Formula
desc "foo"
url 'http://example.com/foo-1.0.tgz'
test do
ENV.fortran
end
end
EOS
expected_offenses = [{ message: "Use `depends_on :fortran` instead of `ENV.fortran`",
severity: :convention,
line: 5,
column: 4,
source: source }]
inspect_source(cop, source)
expected_offenses.zip(cop.offenses).each do |expected, actual|
expect_offense(expected, actual)
end
end
end
def expect_offense(expected, actual)
expect(actual.message).to eq(expected[:message])