admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Re-enable GNU mirror audit

Browse Source 
Follow-up to Homebrew/brew#20461 and #233493.
This commit is contained in:
Ruoyu Zhong 2025-08-14 22:36:09 +08:00
parent eb114387fb
commit 3f4d19e87b
No known key found for this signature in database
2 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/rubocops/shared/url_helper.rb
View File

@ -41,11 +41,11 @@ module RuboCop
problem "Please use the ASCII (Punycode-encoded host, URL-encoded path and query) version of #{url}."
end
# TODO: Re-add the following audit after homebrew/core migration.
# gnu_pattern = %r{^(?:https?|ftp)://ftp\.gnu\.org/(.*)}
# audit_urls(urls, gnu_pattern) do |match, url|
# problem "#{url} should be: https://ftpmirror.gnu.org/gnu/#{match[1]}"
# end
# Prefer ftpmirror.gnu.org as suggested by https://www.gnu.org/prep/ftp.en.html
gnu_pattern = %r{^(?:https?|ftp)://ftp\.gnu\.org/(.*)}
audit_urls(urls, gnu_pattern) do |match, url|
problem "#{url} should be: https://ftpmirror.gnu.org/gnu/#{match[1]}"
end
# Fossies upstream requests they aren't used as primary URLs
# https://github.com/Homebrew/homebrew-core/issues/14486#issuecomment-307753234

12
Library/Homebrew/test/rubocops/urls_spec.rb
View File

@ -6,14 +6,12 @@ RSpec.describe RuboCop::Cop::FormulaAudit::Urls do
subject(:cop) { described_class.new }
let(:offense_list) do
# TODO: Re-add the following to the offense list after homebrew/core migration.
# {
# "url" => "https://ftpmirror.gnu.org/lightning/lightning-2.1.0.tar.gz",
# "msg" => "https://ftpmirror.gnu.org/lightning/lightning-2.1.0.tar.gz should be: " \
# "https://ftp.gnu.org/gnu/lightning/lightning-2.1.0.tar.gz",
# "col" => 2,
# }
[{
"url" => "https://ftp.gnu.org/lightning/lightning-2.1.0.tar.gz",
"msg" => "https://ftp.gnu.org/lightning/lightning-2.1.0.tar.gz should be: " \
"https://ftpmirror.gnu.org/gnu/lightning/lightning-2.1.0.tar.gz",
"col" => 2,
}, {
"url" => "https://fossies.org/linux/privat/monit-5.23.0.tar.gz",
"msg" => "Please don't use \"fossies.org\" in the `url` (using as a mirror is fine)",
"col" => 2,