Apply suggestions from code review

This commit is contained in:
Mike McQuaid 2021-08-31 16:35:09 +01:00 committed by GitHub
parent 16594c5521
commit 3e1c8ea877
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -44,7 +44,7 @@ module Homebrew
formula_installers = formulae_to_install.map do |formula|
Migrator.migrate_if_needed(formula, force: force)
begin
fi = create_formula_installer(
fi = create_and_fetch_formula_installer(
formula,
flags: flags,
installed_on_request: installed_on_request,
@ -89,7 +89,7 @@ module Homebrew
EOS
end
def create_formula_installer(
def create_and_fetch_formula_installer(
formula,
flags:,
installed_on_request: false,
@ -137,7 +137,7 @@ module Homebrew
}.compact,
)
end
private_class_method :create_formula_installer
private_class_method :create_and_fetch_formula_installer
def upgrade_formula(formula_installer, verbose: false)
formula = formula_installer.formula