From 3e092e5e9024db01329fa59ee05b816e0b847748 Mon Sep 17 00:00:00 2001 From: hyuraku <32809703+hyuraku@users.noreply.github.com> Date: Mon, 7 Nov 2022 23:12:07 +0900 Subject: [PATCH] refactor option style --- Library/Homebrew/utils/github.rb | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/Library/Homebrew/utils/github.rb b/Library/Homebrew/utils/github.rb index 1769f1cb43..1aacf3099a 100644 --- a/Library/Homebrew/utils/github.rb +++ b/Library/Homebrew/utils/github.rb @@ -672,14 +672,16 @@ module GitHub output, _, status = curl_output( "--silent", "--head", "--location", - "-H", "Accept: application/vnd.github.sha", + "--header", "Accept: application/vnd.github.sha", "https://api.github.com/repos/#{user}/#{repo}/commits/#{ref}" ) return unless status.success? commit = output[/^ETag: "(\h+)"/, 1] - version.update_commit(commit) if commit + return if commit.blank? + + version.update_commit(commit) commit end @@ -688,10 +690,14 @@ module GitHub output, _, status = curl_output( "--silent", "--head", "--location", - "-H", "Accept: application/vnd.github.sha", + "--header", "Accept: application/vnd.github.sha", "https://api.github.com/repos/#{user}/#{repo}/commits/#{commit}" ) - !(status.success? && output && output[/^Status: (200)/, 1] == "200") + return true if status.success? + return true unless output + return true if output[/^Status: (200)/, 1] != "200" + + false end end