Improve libiconv diagnostic and suggestion

This is coming up a lot at the moment, so here is an attempt to be more helpful.

Library/Homebrew/cmd/doctor.rb

@@ -40,6 +40,7 @@ end
 class Checks
   # Sorry for the lack of an indent here, the diff would have been unreadable.
 
+############# HELPERS
 def remove_trailing_slash s
   (s[s.length-1] == '/') ? s[0,s.length-1] : s
 end
@@ -54,6 +55,15 @@ def path_folders
   end.uniq.compact
 end
 
+  # Finds files in HOMEBREW_PREFIX *and* /usr/local.
+  # Specify paths relative to a prefix eg. "include/foo.h".
+  # Sets @found for your convenience.
+  def find_relative_paths *relative_paths
+    @found = %W[#{HOMEBREW_PREFIX} /usr/local].uniq.inject([]) do |found, prefix|
+      found + relative_paths.map{|f| File.join(prefix, f) }.select{|f| File.exist? f }
+    end
+  end
+############# END HELPERS
 
 # See https://github.com/mxcl/homebrew/pull/9986
 def check_path_for_trailing_slashes
@@ -514,20 +524,28 @@ def check_for_gettext
 end
 
 def check_for_iconv
-  iconv_files = %w[lib/iconv.dylib
+  unless find_relative_paths("lib/iconv.dylib", "include/iconv.h").empty?
-    include/iconv.h].select { |f| File.exist? "#{HOMEBREW_PREFIX}/#{f}" }
+    if (f = Formula.factory("libiconv") rescue nil) and f.linked_keg.directory?
-  if !iconv_files.empty?
+      if not f.keg_only? then <<-EOS.undent
-    <<-EOS.undent
+        A libiconv formula is installed and linked
-      The following libiconv files were detected in #{HOMEBREW_PREFIX}:
+        This will break stuff. For serious. Unlink it.
-      #{iconv_files.join "\n      "}
+        EOS
-      Homebrew doesn't provide a libiconv formula, and expects to link against
+      else
-      the system version in /usr/lib.
+        # NOOP because: check_for_linked_keg_only_brews
+      end
+    else
+      s = <<-EOS.undent_________________________________________________________72
+          libiconv files detected at a system prefix other than /usr
+          Homebrew doesn't provide a libiconv formula, and expects to link against
+          the system version in /usr. libiconv in other prefixes can cause
+          compile or link failure, especially if compiled with improper
+          architectures. OS X itself never installs anything to /usr/local so
+          it was either installed by a user or some other third party software.
 
-      If you have an alternate libiconv, many formulae will fail to compile or
+          tl;dr: delete these files:
-      link, especially if it wasn't compiled with the proper architectures.
+          EOS
-    EOS
+      @found.inject(s){|s, f| s << "    #{f}" }
-  else
+    end
-    nil
   end
 end
 
@@ -787,10 +805,13 @@ end
 def check_git_status
   return unless which "git"
   HOMEBREW_REPOSITORY.cd do
-    unless `git status -s -- Library/Homebrew/ 2>/dev/null`.chomp.empty? then <<-EOS.undent
+    unless `git status -s -- Library/Homebrew/ 2>/dev/null`.chomp.empty?
-      You have uncommitted modifications to Homebrew's core.
+      <<-EOS.undent_________________________________________________________72
-      Unless you know what you are doing, you should run:
+      You have uncommitted modifications to Homebrew
-        cd #{HOMEBREW_REPOSITORY}/Library && git reset --hard && git clean -f
+      If this a surprise to you, then you should stash these modifications.
+      Stashing returns Homebrew to a pristine state but can be undone
+      should you later need to do so for some reason.
+          cd #{HOMEBREW_REPOSITORY} && git stash
       EOS
     end
   end

Library/Homebrew/extend/string.rb

@@ -3,6 +3,18 @@ class String
     gsub(/^.{#{slice(/^ +/).length}}/, '')
   end
 
+  # eg:
+  #   if foo then <<-EOS.undent_________________________________________________________72
+  #               Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do
+  #               eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad
+  #               minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip
+  #               ex ea commodo consequat. Duis aute irure dolor in reprehenderit in
+  #               voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur
+  #               sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt
+  #               mollit anim id est laborum.
+  #               EOS
+  alias_method :undent_________________________________________________________72, :undent
+
   unless String.method_defined?(:start_with?)
     def start_with? prefix
       prefix = prefix.to_s