From 7d16fd9186ea8519448233e09b0d022d15a11637 Mon Sep 17 00:00:00 2001 From: Rylan Polster Date: Mon, 15 Jul 2024 12:22:02 -0400 Subject: [PATCH] Revert "sandbox: deny signal to other processes" --- Library/Homebrew/sandbox.rb | 1 - Library/Homebrew/test/sandbox_spec.rb | 18 ------------------ 2 files changed, 19 deletions(-) diff --git a/Library/Homebrew/sandbox.rb b/Library/Homebrew/sandbox.rb index aea0c99f2e..5fe1f43766 100644 --- a/Library/Homebrew/sandbox.rb +++ b/Library/Homebrew/sandbox.rb @@ -302,7 +302,6 @@ class Sandbox (literal "/bin/ps") (with no-sandbox) ) ; allow certain processes running without sandbox - (deny signal (target others)) ; deny sending signals to other processes (allow default) ; allow everything else ERB diff --git a/Library/Homebrew/test/sandbox_spec.rb b/Library/Homebrew/test/sandbox_spec.rb index a28389b427..fee72c130c 100644 --- a/Library/Homebrew/test/sandbox_spec.rb +++ b/Library/Homebrew/test/sandbox_spec.rb @@ -129,22 +129,4 @@ RSpec.describe Sandbox, :needs_macos do end end end - - describe "disallow sending signal to other processes" do - # we have to spawn a process, otherwise kill doesn't try to send a signal if the process doesn't exist - let(:pid) do - pid = spawn("sleep 1000") - sleep 0.1 # Ensure the process has started - pid - end - - after do - Process.kill("KILL", pid) - Process.wait(pid) - end - - it "sandbox stops signal to other processes" do - expect { sandbox.exec "kill", "-SIGTERM", pid.to_s }.to raise_error(ErrorDuringExecution) - end - end end