From 3d9c6ddb755d881756e2bd55c108ce13e92839f5 Mon Sep 17 00:00:00 2001 From: Mohammad Zain Abbas Date: Sun, 18 Sep 2022 17:09:21 +0200 Subject: [PATCH] Minor fix: return error when `resource_version` method returns empty hash --- Library/Homebrew/livecheck/livecheck.rb | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/Library/Homebrew/livecheck/livecheck.rb b/Library/Homebrew/livecheck/livecheck.rb index 0195e2f7a7..b7c5b7c8c2 100644 --- a/Library/Homebrew/livecheck/livecheck.rb +++ b/Library/Homebrew/livecheck/livecheck.rb @@ -251,13 +251,22 @@ module Homebrew if check_for_resources resource_version_info = formula_or_cask.resources.map do |resource| res_skip_info ||= SkipConditions.skip_information(resource, verbose: verbose) - res_skip_info.presence || resource_version( - resource, - json: json, - verbose: verbose, - debug: debug, - ) - end.compact + if res_skip_info.present? + res_skip_info + else + res_version_info = resource_version( + resource, + json: json, + verbose: verbose, + debug: debug, + ) + if res_version_info.empty? + status_hash(resource, "error", ["Unable to get versions"], verbose: verbose) + else + res_version_info + end + end + end.compact_blank end skip_info ||= SkipConditions.skip_information(formula_or_cask, full_name: use_full_name, verbose: verbose) @@ -704,6 +713,7 @@ module Homebrew next end end + puts if debug && strategy.blank? next if strategy.blank? strategy_data = strategy.find_versions(