update: only compute tapd_basename when necessary

2015-08-15 18:32:22 +08:00 · 2015-08-15 18:32:22 +08:00 · 3c45e1e81d
commit 3c45e1e81d
parent 0bf2f92f46
1 changed files with 1 additions and 2 deletions
--- a/Library/Homebrew/cmd/update.rb
+++ b/Library/Homebrew/cmd/update.rb
@ -122,9 +122,8 @@ module Homebrew
  def rename_taps_dir_if_necessary
    Dir.glob("#{HOMEBREW_LIBRARY}/Taps/*/") do |tapd|
      begin
-        tapd_basename = File.basename(tapd)
-
        if File.directory?(tapd + "/.git")
+          tapd_basename = File.basename(tapd)
          if tapd_basename.include?("-")
            # only replace the *last* dash: yes, tap filenames suck
            user, repo = tapd_basename.reverse.sub("-", "/").reverse.split("/")