From 8666d8fa18494e73713a130378f842959882d1f8 Mon Sep 17 00:00:00 2001 From: Claudia Date: Sun, 22 Jul 2018 16:27:16 +0200 Subject: [PATCH] Increase spec timeout to 30 seconds MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I’ve noticed the deadlock test in `cask/system_command_spec.rb` appears to fail spuriously, e. g. in #4529. Details: https://travis-ci.org/Homebrew/brew/jobs/406827725#L297-L318 With the spec taking 2 seconds on average on my 2017 MBP, I feel it’s entirely plausible for the aging test-bot hardware to get knocked by the 15-second timeout. Given that the spec will pass early anyway if it passes, I feel it’s reasonable to bump the timeout to 30 seconds. --- Library/Homebrew/test/cask/system_command_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/test/cask/system_command_spec.rb b/Library/Homebrew/test/cask/system_command_spec.rb index b589e979ec..eb6f8e0515 100644 --- a/Library/Homebrew/test/cask/system_command_spec.rb +++ b/Library/Homebrew/test/cask/system_command_spec.rb @@ -183,7 +183,7 @@ describe Hbc::SystemCommand, :cask do } it "returns without deadlocking" do - wait(15).for { + wait(30).for { described_class.run(command, options) }.to be_a_success end