admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: git tags should also specify revisions.

Browse Source
This commit is contained in:
Mike McQuaid 2015-03-07 15:02:25 +00:00
parent b6a0105b7e
commit 3b15382029
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Library/Homebrew/cmd/audit.rb
View File

@ -872,6 +872,14 @@ class ResourceAuditor
problem "Use of the #{$&} scheme is deprecated, pass `:using => :#{$1}` instead" problem "Use of the #{$&} scheme is deprecated, pass `:using => :#{$1}` instead"
end end
url_strategy = DownloadStrategyDetector.detect(url)
if using == :git || url_strategy == GitDownloadStrategy
if specs[:tag] && !specs[:revision]
problem "Git should specify :revision when a :tag is specified."
end
end
return unless using return unless using
if using == :ssl3 || using == CurlSSL3DownloadStrategy if using == :ssl3 || using == CurlSSL3DownloadStrategy
@ -898,7 +906,6 @@ class ResourceAuditor
end end
end end
url_strategy = DownloadStrategyDetector.detect(url)
using_strategy = DownloadStrategyDetector.detect('', using) using_strategy = DownloadStrategyDetector.detect('', using)
if url_strategy == using_strategy if url_strategy == using_strategy