From 39eb93e0f5ea8276add9e7a4db660ac69db02002 Mon Sep 17 00:00:00 2001 From: Xu Cheng Date: Fri, 15 Jan 2016 19:44:04 +0800 Subject: [PATCH] test-bot: simplify Test#initialize --- Library/Homebrew/cmd/test-bot.rb | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/Library/Homebrew/cmd/test-bot.rb b/Library/Homebrew/cmd/test-bot.rb index 8eb1348280..d02373973d 100644 --- a/Library/Homebrew/cmd/test-bot.rb +++ b/Library/Homebrew/cmd/test-bot.rb @@ -209,16 +209,13 @@ module Homebrew @added_formulae = [] @modified_formula = [] @steps = [] - @tap = options[:tap] + @tap = options.fetch(:tap, CoreFormulaRepository.instance) @repository = @tap.path - @skip_homebrew = options[:skip_homebrew] + @skip_homebrew = options.fetch(:skip_homebrew, false) - url_match = argument.match HOMEBREW_PULL_OR_COMMIT_URL_REGEX - - git "rev-parse", "--verify", "-q", argument - if $?.success? + if quiet_system "git", "rev-parse", "--verify", "-q", argument @hash = argument - elsif url_match + elsif url_match = argument.match(HOMEBREW_PULL_OR_COMMIT_URL_REGEX) @url = url_match[0] elsif safe_formulary(argument) @formulae = [argument]