diff --git a/Library/Homebrew/linkage_checker.rb b/Library/Homebrew/linkage_checker.rb index db753fc9b0..aae8a94e6c 100644 --- a/Library/Homebrew/linkage_checker.rb +++ b/Library/Homebrew/linkage_checker.rb @@ -70,14 +70,16 @@ class LinkageChecker display_items "Broken dependencies", @broken_deps, puts_output: puts_output display_items "Unwanted system libraries", @unwanted_system_dylibs, puts_output: puts_output display_items "Conflicting libraries", @version_conflict_deps, puts_output: puts_output - display_items "Undeclared dependencies with linkage", @undeclared_deps, puts_output: puts_output if strict + return unless strict + + display_items "Undeclared dependencies with linkage", @undeclared_deps, puts_output: puts_output display_items "Files with missing rpath", @files_missing_rpaths, puts_output: puts_output end sig { params(strict: T::Boolean).returns(T::Boolean) } def broken_library_linkage?(strict: false) - issues = [@broken_deps, @unwanted_system_dylibs, @version_conflict_deps, @files_missing_rpaths] - issues << @undeclared_deps if strict + issues = [@broken_deps, @unwanted_system_dylibs, @version_conflict_deps] + issues += [@undeclared_deps, @files_missing_rpaths] if strict [issues, unexpected_broken_dylibs, unexpected_present_dylibs].flatten.any?(&:present?) end