Cache glibc.version

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-04-02 10:53:47 -07:00 · 2021-04-02 10:53:47 -07:00 · 393027597b
commit 393027597b
parent 95e7e010ee
1 changed files with 8 additions and 7 deletions
--- a/Library/Homebrew/os/linux/glibc.rb
+++ b/Library/Homebrew/os/linux/glibc.rb
@ -21,13 +21,14 @@ module OS
      end

      def version
-        return @version if @version
-
-        ldd = HOMEBREW_PREFIX/"opt/glibc/bin/ldd"
-        version = Utils.popen_read(ldd, "--version")[/ (\d+\.\d+)/, 1] if ldd.executable?
-        return system_version unless version
-
-        @version = Version.new version
+        @version ||= begin
+          ldd = HOMEBREW_PREFIX/"opt/glibc/bin/ldd"
+          version = Utils.popen_read(ldd, "--version")[/ (\d+\.\d+)/, 1] if ldd.executable?
+          if version
+            Version.new version
+          else
+            system_version
+          end
      end

      sig { returns(Version) }