admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

missing_formula: note on shallow clones.

Browse Source 
This avoids the user confusion on incomplete results seen in
http://discourse.brew.sh/t/missing-formula-location/818/7
This commit is contained in:
Mike McQuaid 2017-06-03 10:02:40 +01:00
parent 0731a68cde
commit 390bf44f69
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/missing_formula.rb
View File

@ -126,10 +126,17 @@ module Homebrew
relative_path = path.relative_path_from tap.path relative_path = path.relative_path_from tap.path
tap.path.cd do tap.path.cd do
ohai "Searching for a previously deleted formula..." unless silent unless silent
ohai "Searching for a previously deleted formula..."
if (tap.path/".git/shallow").exist?
opoo <<-EOS.undent
#{tap} is shallow clone. To get complete history run:
git -C "$(brew --repo #{tap})" fetch --unshallow
EOS
end
end
# We know this may return incomplete results for shallow clones but
# we don't want to nag everyone with a shallow clone to unshallow it.
log_command = "git log --name-only --max-count=1 --format=%H\\\\n%h\\\\n%B -- #{relative_path}" log_command = "git log --name-only --max-count=1 --format=%H\\\\n%h\\\\n%B -- #{relative_path}"
hash, short_hash, *commit_message, relative_path = hash, short_hash, *commit_message, relative_path =
Utils.popen_read(log_command).gsub("\\n", "\n").lines.map(&:chomp) Utils.popen_read(log_command).gsub("\\n", "\n").lines.map(&:chomp)