admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: catch unnecessary 'ENV.foo' interpolation

Browse Source 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Jack Nagel 2012-06-17 17:58:49 -05:00
parent 58d4a95ea7
commit 38a28285a6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/cmd/audit.rb
View File

@ -53,7 +53,7 @@ def audit_formula_text name, text
end end
# Check for string interpolation of single values. # Check for string interpolation of single values.
if text =~ /(system|inreplace|gsub!|change_make_var!) .* ['"]#\{(\w+)\}['"]/ if text =~ /(system|inreplace|gsub!|change_make_var!) .* ['"]#\{(\w+(\.\w+)?)\}['"]/
problems << " * Don't need to interpolate \"#{$2}\" with #{$1}" problems << " * Don't need to interpolate \"#{$2}\" with #{$1}"
end end