formula_auditor: remove issue comment audit

See discussion at Homebrew/homebrew-core#128954.
This commit is contained in:
Carlo Cabrera 2023-04-22 01:27:35 +08:00
parent 302b224c21
commit 3631765a8d
No known key found for this signature in database
GPG Key ID: C74D447FC549A1D0

View File

@ -826,28 +826,6 @@ module Homebrew
end
end
def audit_github_issue_comment
return unless @online
matches = text.to_s.scan(%r{https://github.com/([-\w_]*)/([-\w_]*)/(pull|issues)/([0-9]*)})
return unless matches
matches.each do |match|
owner, repo, type, id = match
# Do not trigger for self references
next if "#{owner}/#{repo}" == formula.tap.remote_repo || owner == "Homebrew"
issue = GitHub::API.open_rest("https://api.github.com/repos/#{owner}/#{repo}/issues/#{id}")
next if issue.blank?
next if issue["state"] == "open"
next if issue.dig("pull_request", "merged_at").present?
issue_url = "https://github.com/#{owner}/#{repo}/#{type}/#{id}"
problem "Formula refers to a GitHub issue or pull request that is closed: #{issue_url}"
end
end
def audit_reverse_migration
# Only enforce for new formula being re-added to core
return unless @strict