Remove duplication from cleanup methods

This commit is contained in:
Jack Nagel 2015-04-07 21:14:32 -04:00
parent 1aff1d9455
commit 3587dc441e

View File

@ -25,14 +25,7 @@ module Homebrew
return unless HOMEBREW_LOGS.directory? return unless HOMEBREW_LOGS.directory?
time = Time.now - 2 * 7 * 24 * 60 * 60 # two weeks time = Time.now - 2 * 7 * 24 * 60 * 60 # two weeks
HOMEBREW_LOGS.subdirs.each do |dir| HOMEBREW_LOGS.subdirs.each do |dir|
if dir.mtime < time cleanup_path(dir) { dir.rmtree } if dir.mtime < time
if ARGV.dry_run?
puts "Would remove: #{dir}"
else
puts "Removing: #{dir}..."
dir.rmtree
end
end
end end
end end
@ -66,11 +59,8 @@ module Homebrew
def cleanup_keg keg def cleanup_keg keg
if keg.linked? if keg.linked?
opoo "Skipping (old) #{keg} due to it being linked" opoo "Skipping (old) #{keg} due to it being linked"
elsif ARGV.dry_run?
puts "Would remove: #{keg} (#{keg.abv})"
else else
puts "Removing: #{keg}... (#{keg.abv})" cleanup_path(keg) { keg.uninstall }
keg.uninstall
end end
end end
@ -87,17 +77,17 @@ module Homebrew
end end
if f.version > version || ARGV.switch?('s') && !f.installed? || bottle_file_outdated?(f, file) if f.version > version || ARGV.switch?('s') && !f.installed? || bottle_file_outdated?(f, file)
cleanup_cached_file(file) cleanup_path(file) { file.unlink }
end end
end end
end end
def cleanup_cached_file file def cleanup_path(path)
if ARGV.dry_run? if ARGV.dry_run?
puts "Would remove: #{file} (#{file.abv})" puts "Would remove: #{path} (#{path.abv})"
else else
puts "Removing: #{file}... (#{file.abv})" puts "Removing: #{path}... (#{path.abv})"
file.unlink yield
end end
end end