From 3484db71d008caf65d1d16e0e3db8410d80e73cd Mon Sep 17 00:00:00 2001 From: Maxim Belkin Date: Sat, 7 Apr 2018 15:35:27 -0500 Subject: [PATCH] fix missing_deps --- Library/Homebrew/linkage_checker.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/linkage_checker.rb b/Library/Homebrew/linkage_checker.rb index c840b1fde7..75b50966c6 100644 --- a/Library/Homebrew/linkage_checker.rb +++ b/Library/Homebrew/linkage_checker.rb @@ -13,7 +13,7 @@ class LinkageChecker @brewed_dylibs = Hash.new { |h, k| h[k] = Set.new } @system_dylibs = Set.new @broken_dylibs = [] - @broken_deps = Hash.new { |h, k| h[k] = Set.new } + @broken_deps = Hash.new { |h, k| h[k] = [] } @variable_dylibs = Set.new @indirect_deps = [] @undeclared_deps = [] @@ -48,7 +48,7 @@ class LinkageChecker rescue Errno::ENOENT next if harmless_broken_link?(dylib) if (dep = dylib_to_dep(dylib)) - @broken_deps[dep] << dylib + @broken_deps[dep] |= [dylib] else @broken_dylibs << dylib end @@ -96,7 +96,7 @@ class LinkageChecker next true if Formula[name].bin.directory? @brewed_dylibs.keys.map { |x| x.split("/").last }.include?(name) end - missing_deps = @broken_deps.values.flat_map { |d| dylib_to_dep(d) }.compact + missing_deps = @broken_deps.values.flatten.map { |d| dylib_to_dep(d) } unnecessary_deps -= missing_deps [indirect_deps, undeclared_deps, unnecessary_deps] end