admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: check virtualenv and setuptools resource.

Browse Source 
`virtualenv_install_with_resources` will automatically define and
install a `setuptools` resource so this is unnecessary.

References https://github.com/Homebrew/homebrew-core/pull/8570
This commit is contained in:
Mike McQuaid 2017-01-09 13:24:51 +00:00
parent f7bccee214
commit 346d68eb04
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Library/Homebrew/dev-cmd/audit.rb
View File

@ -819,6 +819,11 @@ class FormulaAuditor
problem "Formulae should not depend on both OpenSSL and LibreSSL (even optionally)." problem "Formulae should not depend on both OpenSSL and LibreSSL (even optionally)."
end end
if text =~ /virtualenv_(create|install_with_resources)/ &&
text =~ /resource\s+['"]setuptools['"]\s+do/
problem "Formulae using virtualenvs do not need a `setuptools` resource."
end
return unless text.include?('require "language/go"') && !text.include?("go_resource") return unless text.include?('require "language/go"') && !text.include?("go_resource")
problem "require \"language/go\" is unnecessary unless using `go_resource`s" problem "require \"language/go\" is unnecessary unless using `go_resource`s"
end end