From 33f1c3164b1c6a9ef2d3de0e7cb139b259808bad Mon Sep 17 00:00:00 2001 From: William Ma Date: Thu, 23 Jul 2020 12:23:36 -0400 Subject: [PATCH] commands: Use a hash instead of nested arrays --- Library/Homebrew/cmd/commands.rb | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/Library/Homebrew/cmd/commands.rb b/Library/Homebrew/cmd/commands.rb index 999288569f..c35a354679 100644 --- a/Library/Homebrew/cmd/commands.rb +++ b/Library/Homebrew/cmd/commands.rb @@ -31,18 +31,20 @@ module Homebrew return end - first = true + prepend_separator = false - [["Built-in commands", Commands.internal_commands], - ["Built-in developer commands", Commands.internal_developer_commands], - ["External commands", Commands.external_commands], - ["Cask commands", Commands.cask_internal_commands], - ["External cask commands", Commands.cask_external_commands]] + { "Built-in commands" => Commands.internal_commands, + "Built-in developer commands" => Commands.internal_developer_commands, + "External commands" => Commands.external_commands, + "Cask commands" => Commands.cask_internal_commands, + "External cask commands" => Commands.cask_external_commands } .each do |title, commands| - if commands.present? - first = !first && puts - ohai title, Formatter.columns(commands) - end + next if commands.blank? + + puts if prepend_separator + ohai title, Formatter.columns(commands) + + prepend_separator = true end end end