admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: don't allow use of OS.mac?/OS.linux?.

Browse Source 
Forbid their use in Homebrew/core which only supports macOS. This may
be added to more/all official taps in future.
This commit is contained in:
Mike McQuaid 2016-12-13 02:32:38 +00:00
parent 201b45d2ca
commit 339ff9400f
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Library/Homebrew/dev-cmd/audit.rb
View File

@ -1004,6 +1004,13 @@ class FormulaAuditor
problem "'fails_with :llvm' is now a no-op so should be removed" problem "'fails_with :llvm' is now a no-op so should be removed"
end end
if formula.tap.to_s == "homebrew/core"
["OS.mac?", "OS.linux?"].each do |check|
next unless line.include?(check)
problem "Don't use #{check}; Homebrew/core only supports macOS"
end
end
return unless @strict return unless @strict
if line =~ /system ((["'])[^"' ]*(?:\s[^"' ]*)+\2)/ if line =~ /system ((["'])[^"' ]*(?:\s[^"' ]*)+\2)/