Merge pull request #11051 from Bo98/better-debrew-raise

debrew: make Debrew::Raise only catch uncaught exceptions

Library/Homebrew/debrew.rb

@@ -3,6 +3,10 @@
 
 require "mutex_m"
 require "debrew/irb"
+require "warnings"
+Warnings.ignore(/warning: callcc is obsolete; use Fiber instead/) do
+  require "continuation"
+end
 
 # Helper module for debugging formulae.
 #
@@ -10,15 +14,26 @@ require "debrew/irb"
 module Debrew
   extend Mutex_m
 
-  Ignorable = Module.new.freeze
+  # Marks exceptions which can be ignored and provides
+  # the ability to jump back to where it was raised.
+  module Ignorable
+    attr_accessor :continuation
+
+    def ignore
+      continuation.call
+    end
+  end
 
   # Module for allowing to ignore exceptions.
   module Raise
     def raise(*)
-      super
+      callcc do |continuation|
-    rescue Exception => e # rubocop:disable Lint/RescueException
+        super
-      e.extend(Ignorable)
+      rescue Exception => e # rubocop:disable Lint/RescueException
-      super(e) unless Debrew.debug(e) == :ignore
+        e.extend(Ignorable)
+        e.continuation = continuation
+        super(e)
+      end
     end
 
     alias fail raise
@@ -105,7 +120,7 @@ module Debrew
     rescue SystemExit
       original_raise
     rescue Exception => e # rubocop:disable Lint/RescueException
-      debug(e)
+      e.ignore if debug(e) == :ignore # execution jumps back to where the exception was thrown
     ensure
       @active = false
     end

Library/Homebrew/formula_installer.rb

@@ -9,7 +9,6 @@ require "caveats"
 require "cleaner"
 require "formula_cellar_checks"
 require "install_renamed"
-require "debrew"
 require "sandbox"
 require "development_tools"
 require "cache_store"