From 1ffbcc04d43b809053a1f2c14f0fd6b5c055e702 Mon Sep 17 00:00:00 2001 From: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Date: Sun, 28 Nov 2021 21:47:21 +0800 Subject: [PATCH] rubocops/lines: allow `OS.foo?` in `service` blocks These seem more natural, and I don't think we need to be able to mock service blocks on other OSs. See Homebrew/homebrew-core#90091. --- Library/Homebrew/rubocops/lines.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/rubocops/lines.rb b/Library/Homebrew/rubocops/lines.rb index 08b52b056b..5f941a663e 100644 --- a/Library/Homebrew/rubocops/lines.rb +++ b/Library/Homebrew/rubocops/lines.rb @@ -354,7 +354,7 @@ module RuboCop def audit_formula(_node, _class_node, _parent_class_node, body_node) no_on_os_method_names = [:install, :post_install].freeze - no_on_os_block_names = [:test].freeze + no_on_os_block_names = [:service, :test].freeze [[:on_macos, :mac?], [:on_linux, :linux?]].each do |on_method_name, if_method_name| if_method_and_class = "if OS.#{if_method_name}" no_on_os_method_names.each do |formula_method_name|