Don't use exceptions for flow-control

2013-08-06 19:24:18 -05:00 · 2013-08-06 19:24:18 -05:00 · 326f50ae3f
commit 326f50ae3f
parent e7ee57d5e5
1 changed files with 5 additions and 3 deletions
--- a/Library/Homebrew/superenv.rb
+++ b/Library/Homebrew/superenv.rb
@ -128,12 +128,14 @@ class << ENV
        when 'llvm', 'llvm-gcc' then 'llvm-gcc'
      else
        opoo "Invalid value for HOMEBREW_CC: #{ENV['HOMEBREW_CC'].inspect}"
-        raise # use default
+        default_cc
      end
    else
-      raise
+      default_cc
    end
-  rescue
+  end
+
+  def default_cc
    case MacOS.default_compiler
    when :clang   then 'clang'
    when :llvm    then 'llvm-gcc'