admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

docs/Maintainer-Guidelines: don't merge failing tests.

Browse Source
This commit is contained in:
Mike McQuaid 2018-12-10 14:48:47 +00:00
parent 00075c228c
commit 3245b91900
No known key found for this signature in database
GPG Key ID: 48A898132FD8EE70
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/Maintainer-Guidelines.md
View File

@ -85,6 +85,11 @@ If the formula uses a repository, then the `url` parameter should have a
tag or revision. `url`s have versions and are stable (not yet tag or revision. `url`s have versions and are stable (not yet
implemented!). implemented!).
Don't merge any formula updates with failing `brew test`s. If a `test do` block
is failing it needs to be fixed. This may involve replacing more involved tests
with those that are more reliable. This is fine: false positives are better than
false negatives as we don't want to teach maintainers to merge red PRs.
## Common “gotchas” ## Common “gotchas”
1. [Ensure you have set your username and email address 1. [Ensure you have set your username and email address
properly](https://help.github.com/articles/setting-your-email-in-git/) properly](https://help.github.com/articles/setting-your-email-in-git/)