admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Maintainer-Guidelines: note refactoring PR review.

Browse Source
This commit is contained in:
Mike McQuaid 2020-10-26 12:46:10 +00:00
parent f64e1fcf8f
commit 2e957b24b9
No known key found for this signature in database
GPG Key ID: 48A898132FD8EE70
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/Maintainer-Guidelines.md
View File

@ -159,7 +159,7 @@ Any maintainer can revert a PR created by another maintainer after a user submit
### Give time for other maintainers to review ### Give time for other maintainers to review
PRs that are an "enhancement" to existing functionality i.e. not a fix to an open user issue/discussion, not a version bump, not a security fix, not a fix for CI failure, a usability improvement, a new feature etc. should wait 24h Monday - Friday before being merged. For example, PRs that are an "enhancement" to existing functionality i.e. not a fix to an open user issue/discussion, not a version bump, not a security fix, not a fix for CI failure, a usability improvement, a new feature, refactoring etc. should wait 24h Monday - Friday before being merged. For example,
- a new feature PR submitted at 5pm on Thursday should wait until 5pm on Friday before it is merged - a new feature PR submitted at 5pm on Thursday should wait until 5pm on Friday before it is merged
- a usability fix PR submitted at 5pm on Friday should wait until 5pm on Monday before it is merged - a usability fix PR submitted at 5pm on Friday should wait until 5pm on Monday before it is merged