From 2e360112e4b84fa5fafe17c400043970578a2db7 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Tue, 9 Aug 2016 19:17:56 +0100 Subject: [PATCH] analytics.*: use curl --data for readability. --- Library/Homebrew/utils/analytics.rb | 14 +++++++------- Library/Homebrew/utils/analytics.sh | 16 ++++++++-------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/Library/Homebrew/utils/analytics.rb b/Library/Homebrew/utils/analytics.rb index 087c695400..866ff15f0f 100644 --- a/Library/Homebrew/utils/analytics.rb +++ b/Library/Homebrew/utils/analytics.rb @@ -16,13 +16,13 @@ module Utils args = %W[ --max-time 3 --user-agent #{HOMEBREW_USER_AGENT_CURL} - -d v=1 - -d tid=#{ENV["HOMEBREW_ANALYTICS_ID"]} - -d cid=#{ENV["HOMEBREW_ANALYTICS_USER_UUID"]} - -d aip=1 - -d an=#{HOMEBREW_PRODUCT} - -d av=#{HOMEBREW_VERSION} - -d t=#{type} + --data v=1 + --data aip=1 + --data t=#{type} + --data tid=#{ENV["HOMEBREW_ANALYTICS_ID"]} + --data cid=#{ENV["HOMEBREW_ANALYTICS_USER_UUID"]} + --data an=#{HOMEBREW_PRODUCT} + --data av=#{HOMEBREW_VERSION} ] metadata.each { |k, v| args << "-d" << "#{k}=#{v}" if k && v } diff --git a/Library/Homebrew/utils/analytics.sh b/Library/Homebrew/utils/analytics.sh index 3063716d71..24480b1856 100644 --- a/Library/Homebrew/utils/analytics.sh +++ b/Library/Homebrew/utils/analytics.sh @@ -93,14 +93,14 @@ report-analytics-screenview-command() { local args=( --max-time 3 --user-agent "$HOMEBREW_USER_AGENT_CURL" - -d v=1 - -d tid="$HOMEBREW_ANALYTICS_ID" - -d cid="$HOMEBREW_ANALYTICS_USER_UUID" - -d aip=1 - -d an="$HOMEBREW_PRODUCT" - -d av="$HOMEBREW_VERSION" - -d t=screenview - -d cd="$HOMEBREW_COMMAND" + --data v=1 + --data aip=1 + --data t=screenview + --data tid="$HOMEBREW_ANALYTICS_ID" + --data cid="$HOMEBREW_ANALYTICS_USER_UUID" + --data an="$HOMEBREW_PRODUCT" + --data av="$HOMEBREW_VERSION" + --data cd="$HOMEBREW_COMMAND" ) # Send analytics. Don't send or store any personally identifiable information.