formula_installer: improve no-bottle error message

Closes #10180.
This commit is contained in:
carlocab 2020-12-30 14:11:45 +00:00
parent ff931c2f2c
commit 2dedca337e
No known key found for this signature in database
GPG Key ID: C74D447FC549A1D0

View File

@ -242,8 +242,13 @@ class FormulaInstaller
# Integration tests override homebrew-core locations
ENV["HOMEBREW_TEST_TMPDIR"].nil? &&
!pour_bottle?
raise CannotInstallFormulaError, <<~EOS
#{formula}: no bottle available!
message = <<~EOS
#{formula}: unable to pour bottle!
EOS
if !formula.pour_bottle? && formula.pour_bottle_check_unsatisfied_reason
message += formula.pour_bottle_check_unsatisfied_reason
end
message += <<~EOS
You can try to install from source with e.g.
brew install --build-from-source #{formula}
Please note building from source is unsupported. You will encounter build
@ -251,6 +256,7 @@ class FormulaInstaller
requests instead of asking for help on Homebrew's GitHub, Twitter or any other
official channels.
EOS
raise CannotInstallFormulaError, message
end
type, reason = DeprecateDisable.deprecate_disable_info formula