From 2c5beb0effd113bd0342f052d735d697e3e5af95 Mon Sep 17 00:00:00 2001
From: Mike McQuaid <mike@mikemcquaid.com>
Date: Sat, 10 Sep 2016 10:24:57 +0100
Subject: [PATCH] cmd/upgrade: fix Rubocop warnings.

---
 Library/Homebrew/cmd/upgrade.rb | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/Library/Homebrew/cmd/upgrade.rb b/Library/Homebrew/cmd/upgrade.rb
index d0fa180ce2..1053319bf5 100644
--- a/Library/Homebrew/cmd/upgrade.rb
+++ b/Library/Homebrew/cmd/upgrade.rb
@@ -35,7 +35,7 @@ module Homebrew
       end
 
       (ARGV.resolved_formulae - outdated).each do |f|
-        versions = f.installed_kegs.map { |keg| keg.version }
+        versions = f.installed_kegs.map(&:version)
         if versions.empty?
           onoe "#{f.full_name} not installed"
         else
@@ -51,11 +51,11 @@ module Homebrew
       outdated -= pinned
     end
 
-    unless outdated.empty?
+    if outdated.empty?
+      oh1 "No packages to upgrade"
+    else
       oh1 "Upgrading #{outdated.length} outdated package#{plural(outdated.length)}, with result:"
       puts outdated.map { |f| "#{f.full_name} #{f.pkg_version}" } * ", "
-    else
-      oh1 "No packages to upgrade"
     end
 
     unless upgrade_pinned? || pinned.empty?
@@ -116,6 +116,10 @@ module Homebrew
     ofail e
   ensure
     # restore previous installation state if build failed
-    outdated_keg.link if outdated_keg && !f.installed? rescue nil
+    begin
+      outdated_keg.link if outdated_keg && !f.installed?
+    rescue
+      nil
+    end
   end
 end