From 8aa697363b66e537a3c9689b7dbe18a9f3872dd2 Mon Sep 17 00:00:00 2001
From: Mike McQuaid <mike@mikemcquaid.com>
Date: Fri, 27 Oct 2017 09:01:38 +0100
Subject: [PATCH 1/3] test.flac: add flac fixture.

---
 Library/Homebrew/test/support/fixtures/test.flac | Bin 0 -> 98 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 Library/Homebrew/test/support/fixtures/test.flac

diff --git a/Library/Homebrew/test/support/fixtures/test.flac b/Library/Homebrew/test/support/fixtures/test.flac
new file mode 100644
index 0000000000000000000000000000000000000000..253f14a717a40418b0d2fa33287962b79e841707
GIT binary patch
literal 98
zcmYfENpxmlU{GRdU}<1r-~l4WFAN`mB8;EAAK&(!{KO!pPG#Se_l&bz7#K7ZfD%Qi
yX{kl2dC92?IhjdrK90@`hI&SNh6+Xo2IdBqhUP#e4F7+ma4;}DW@h~RMgRa^(j0yO

literal 0
HcmV?d00001


From 5a8d2352c2012504544cda53eab55eec324f4a82 Mon Sep 17 00:00:00 2001
From: Mike McQuaid <mike@mikemcquaid.com>
Date: Thu, 26 Oct 2017 16:06:29 +0100
Subject: [PATCH 2/3] rubocop.yml: reduce tap maximum line length.

---
 Library/.rubocop.yml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml
index 2580668b4b..051a57f933 100644
--- a/Library/.rubocop.yml
+++ b/Library/.rubocop.yml
@@ -58,7 +58,7 @@ Lint/EndAlignment:
 Lint/ParenthesesAsGroupedExpression:
   Enabled: false
 
-# TODO: try to bring down all metrics maximums
+# most metrics don't make sense to apply for formulae/taps
 Metrics/AbcSize:
   Enabled: false
 
@@ -72,9 +72,10 @@ Metrics/CyclomaticComplexity:
   Enabled: false
 
 Metrics/LineLength:
-  Max: 324
-  # ignore manpage comments
-  IgnoredPatterns: ['#: ']
+  # 124 is the goal as GitHub diff UI wraps beyond that
+  Max: 190
+  # ignore manpage comments and long single-line strings
+  IgnoredPatterns: ['#: ', ' url "', ' mirror "', ' plist_options :']
 
 Metrics/MethodLength:
   Enabled: false

From 47bfad64b05346fc6ba2e0c57cc6c1e2318c109c Mon Sep 17 00:00:00 2001
From: Mike McQuaid <mike@mikemcquaid.com>
Date: Fri, 27 Oct 2017 09:34:38 +0100
Subject: [PATCH 3/3] rubocop.yml: re-add Homebrew metrics maximums.

---
 Library/Homebrew/.rubocop.yml | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/Library/Homebrew/.rubocop.yml b/Library/Homebrew/.rubocop.yml
index 0e1fb2d041..3548677389 100644
--- a/Library/Homebrew/.rubocop.yml
+++ b/Library/Homebrew/.rubocop.yml
@@ -25,6 +25,10 @@ Lint/NestedMethodDefinition:
 Lint/ParenthesesAsGroupedExpression:
   Enabled: true
 
+# TODO: try to bring down all metrics maximums
+Metrics/AbcSize:
+  Max: 250
+
 Metrics/BlockLength:
   Max: 1250
 
@@ -34,12 +38,24 @@ Metrics/BlockNesting:
 Metrics/ClassLength:
   Max: 1226
 
+Metrics/CyclomaticComplexity:
+  Max: 75
+
 Metrics/LineLength:
+  # 124 is the goal as GitHub diff UI wraps beyond that
   Max: 244
+  # ignore manpage comments
+  IgnoredPatterns: ['#: ']
 
 Metrics/MethodLength:
   Max: 195
 
+Metrics/ModuleLength:
+  Max: 222
+
+Metrics/PerceivedComplexity:
+  Max: 100
+
 # we won't change backward compatible method names
 Naming/MethodName:
   Exclude: