diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index 2580668b4b..051a57f933 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -58,7 +58,7 @@ Lint/EndAlignment: Lint/ParenthesesAsGroupedExpression: Enabled: false -# TODO: try to bring down all metrics maximums +# most metrics don't make sense to apply for formulae/taps Metrics/AbcSize: Enabled: false @@ -72,9 +72,10 @@ Metrics/CyclomaticComplexity: Enabled: false Metrics/LineLength: - Max: 324 - # ignore manpage comments - IgnoredPatterns: ['#: '] + # 124 is the goal as GitHub diff UI wraps beyond that + Max: 190 + # ignore manpage comments and long single-line strings + IgnoredPatterns: ['#: ', ' url "', ' mirror "', ' plist_options :'] Metrics/MethodLength: Enabled: false diff --git a/Library/Homebrew/.rubocop.yml b/Library/Homebrew/.rubocop.yml index 0e1fb2d041..3548677389 100644 --- a/Library/Homebrew/.rubocop.yml +++ b/Library/Homebrew/.rubocop.yml @@ -25,6 +25,10 @@ Lint/NestedMethodDefinition: Lint/ParenthesesAsGroupedExpression: Enabled: true +# TODO: try to bring down all metrics maximums +Metrics/AbcSize: + Max: 250 + Metrics/BlockLength: Max: 1250 @@ -34,12 +38,24 @@ Metrics/BlockNesting: Metrics/ClassLength: Max: 1226 +Metrics/CyclomaticComplexity: + Max: 75 + Metrics/LineLength: + # 124 is the goal as GitHub diff UI wraps beyond that Max: 244 + # ignore manpage comments + IgnoredPatterns: ['#: '] Metrics/MethodLength: Max: 195 +Metrics/ModuleLength: + Max: 222 + +Metrics/PerceivedComplexity: + Max: 100 + # we won't change backward compatible method names Naming/MethodName: Exclude: diff --git a/Library/Homebrew/test/support/fixtures/test.flac b/Library/Homebrew/test/support/fixtures/test.flac new file mode 100644 index 0000000000..253f14a717 Binary files /dev/null and b/Library/Homebrew/test/support/fixtures/test.flac differ