From 2bdf0d60683111c96cb96d7cccfee4cf8ae8b372 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Tue, 25 Aug 2020 10:20:17 +0100 Subject: [PATCH] spec_helper: increase tests timeout. When GitHub Actions is congested some tests can take longer than this (particularly as we're running in parallel). Globally double the time we allow for all tests. --- Library/Homebrew/test/cmd/reinstall_spec.rb | 2 +- Library/Homebrew/test/dev-cmd/test_spec.rb | 2 +- Library/Homebrew/test/spec_helper.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/test/cmd/reinstall_spec.rb b/Library/Homebrew/test/cmd/reinstall_spec.rb index 68c67a82dd..45b5a48ffb 100644 --- a/Library/Homebrew/test/cmd/reinstall_spec.rb +++ b/Library/Homebrew/test/cmd/reinstall_spec.rb @@ -7,7 +7,7 @@ describe "Homebrew.reinstall_args" do it_behaves_like "parseable arguments" end -describe "brew reinstall", :integration_test, timeout: 120 do +describe "brew reinstall", :integration_test do it "reinstalls a Formula" do install_test_formula "testball" foo_dir = HOMEBREW_CELLAR/"testball/0.1/bin" diff --git a/Library/Homebrew/test/dev-cmd/test_spec.rb b/Library/Homebrew/test/dev-cmd/test_spec.rb index b3bb257a39..866230a703 100644 --- a/Library/Homebrew/test/dev-cmd/test_spec.rb +++ b/Library/Homebrew/test/dev-cmd/test_spec.rb @@ -7,7 +7,7 @@ describe "Homebrew.test_args" do end # randomly segfaults on Linux with portable-ruby. -describe "brew test", :integration_test, :needs_macos, timeout: 120 do +describe "brew test", :integration_test, :needs_macos do it "tests a given Formula" do install_test_formula "testball", <<~'RUBY' test do diff --git a/Library/Homebrew/test/spec_helper.rb b/Library/Homebrew/test/spec_helper.rb index f8a848e34f..a37f306f58 100644 --- a/Library/Homebrew/test/spec_helper.rb +++ b/Library/Homebrew/test/spec_helper.rb @@ -181,7 +181,7 @@ RSpec.configure do |config| end begin - timeout = example.metadata.fetch(:timeout, 60) + timeout = example.metadata.fetch(:timeout, 120) inner_timeout = nil Timeout.timeout(timeout) do example.run