tests.yml: address review comments

This commit is contained in:
Maxim Belkin 2020-08-12 07:49:55 -05:00
parent 133155397c
commit 2b859282e0
No known key found for this signature in database
GPG Key ID: AC71560D4C5F2338

View File

@ -9,12 +9,15 @@ env:
jobs: jobs:
tests: tests:
if: github.repository == 'Homebrew/brew' if: github.repository == 'Homebrew/brew'
runs-on: ${{ matrix.config.os }} runs-on: ${{ matrix.os }}
strategy: strategy:
matrix: matrix:
config: os: [ubuntu-latest, macOS-latest]
- {os: ubuntu-latest, core-tap: 'linuxbrew-core'} include:
- {os: macOS-latest, core-tap: 'homebrew-core'} - os: ubuntu-latest
core-tap: 'linuxbrew-core'
- os: macOS-latest
core-tap: 'homebrew-core'
steps: steps:
- name: Set up Homebrew - name: Set up Homebrew
id: set-up-homebrew id: set-up-homebrew
@ -26,7 +29,9 @@ jobs:
username: BrewTestBot username: BrewTestBot
- run: brew test-bot --only-cleanup-before - run: brew test-bot --only-cleanup-before
- run: brew config - run: brew config
- run: brew doctor - run: brew doctor
- name: Cache Bundler RubyGems - name: Cache Bundler RubyGems
@ -96,14 +101,14 @@ jobs:
- name: Run brew readall on all taps - name: Run brew readall on all taps
run: brew readall --aliases run: brew readall --aliases
- name: Run brew style on ${{ matrix.config.core-tap }} - name: Run brew style on ${{ matrix.core-tap }}
run: brew style --display-cop-names homebrew/core run: brew style --display-cop-names homebrew/core
- name: Run brew style on official taps - name: Run brew style on official taps
run: brew style --display-cop-names homebrew/bundle homebrew/services homebrew/test-bot run: brew style --display-cop-names homebrew/bundle homebrew/services homebrew/test-bot
- name: Run brew cask style on all taps - name: Run brew cask style on all taps
if: matrix.config.os == 'macOS-latest' if: matrix.os == 'macOS-latest'
run: | run: |
brew tap homebrew/cask brew tap homebrew/cask
brew tap homebrew/cask-drivers brew tap homebrew/cask-drivers
@ -121,13 +126,13 @@ jobs:
vale docs/ vale docs/
- name: Lint Dockerfile - name: Lint Dockerfile
if: matrix.config.os == 'ubuntu-latest' if: matrix.os == 'ubuntu-latest'
run: | run: |
brew install hadolint brew install hadolint
hadolint Dockerfile hadolint Dockerfile
- name: Build Docker image - name: Build Docker image
if: matrix.config.os == 'ubuntu-latest' if: matrix.os == 'ubuntu-latest'
run: docker build -t brew --build-arg=version=16.04 . run: docker build -t brew --build-arg=version=16.04 .
- name: Run brew test-bot --only-formulae --test-default-formula - name: Run brew test-bot --only-formulae --test-default-formula
@ -139,7 +144,7 @@ jobs:
fi fi
- name: Deploy the Docker image to GitHub and Docker Hub - name: Deploy the Docker image to GitHub and Docker Hub
if: matrix.config.os == 'ubuntu-latest' && github.ref == 'refs/heads/master' if: matrix.os == 'ubuntu-latest' && github.ref == 'refs/heads/master'
run: | run: |
docker login docker.pkg.github.com -u BrewTestBot -p ${{secrets.GITHUB_TOKEN}} docker login docker.pkg.github.com -u BrewTestBot -p ${{secrets.GITHUB_TOKEN}}
docker tag brew "docker.pkg.github.com/homebrew/brew/ubuntu16.04:master" docker tag brew "docker.pkg.github.com/homebrew/brew/ubuntu16.04:master"