From 7116b74705589f846428b1af4e0db7ca9feb0302 Mon Sep 17 00:00:00 2001 From: Steven Peters Date: Mon, 29 Oct 2018 14:33:25 -0700 Subject: [PATCH] dev-cmd/bottle: require arg for --root-url --- Library/Homebrew/dev-cmd/bottle.rb | 2 +- Library/Homebrew/test/dev-cmd/bottle_spec.rb | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/dev-cmd/bottle.rb b/Library/Homebrew/dev-cmd/bottle.rb index 6f4c372a31..f25cf9efe6 100644 --- a/Library/Homebrew/dev-cmd/bottle.rb +++ b/Library/Homebrew/dev-cmd/bottle.rb @@ -106,7 +106,7 @@ module Homebrew depends_on: "--write", description: "When passed with `--write`, a new commit will not generated after writing changes "\ "to the formula file." - flag "--root-url", + flag "--root-url=", description: "Use the specified as the root of the bottle's URL instead of Homebrew's default." switch :verbose switch :debug diff --git a/Library/Homebrew/test/dev-cmd/bottle_spec.rb b/Library/Homebrew/test/dev-cmd/bottle_spec.rb index fceb87b5b0..365c85ad26 100644 --- a/Library/Homebrew/test/dev-cmd/bottle_spec.rb +++ b/Library/Homebrew/test/dev-cmd/bottle_spec.rb @@ -12,6 +12,11 @@ describe "brew bottle", :integration_test do .and not_to_output.to_stdout .and be_a_failure + expect { brew "bottle", "--root-url" } + .to output(/missing argument: --root-url/).to_stderr + .and not_to_output.to_stdout + .and be_a_failure + setup_test_formula "testball" # `brew bottle` should not fail with dead symlink