admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #14748 from SMillerDev/feat/cask/audit_short_version_sparkle

Browse Source 
cask: audit if sparkle livecheck needs multipart version
This commit is contained in:
Sean Molenaar 2023-02-22 20:23:17 +01:00 committed by GitHub
commit 2b1fbaa26d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/cask/audit.rb
View File

@ -474,6 +474,16 @@ module Cask
add_error "download not possible: #{e}" add_error "download not possible: #{e}"
end end
sig { void }
def audit_appcast_unneeded_long_version
return unless cask.livecheck.strategy == :sparkle
return unless cask.version.csv.second
return if cask.url.to_s.include? cask.version.csv.second
return if cask.version.csv.third.present? && cask.url.to_s.include?(cask.version.csv.third)
add_warning "Download does not require additional version components. Use `&:short_version` in the livecheck"
end
sig { void } sig { void }
def audit_signing def audit_signing
return if !signing? || download.blank? || cask.url.blank? return if !signing? || download.blank? || cask.url.blank?